-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted DDF schema and credentials validation #385
Merged
Merged
+725
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 29, 2020
Merged
skateman
force-pushed
the
ddf-forms-adjust
branch
2 times, most recently
from
July 2, 2020 12:15
76b4072
to
07972e9
Compare
skateman
force-pushed
the
ddf-forms-adjust
branch
from
July 31, 2020 08:48
07972e9
to
1117e05
Compare
skateman
commented
Jul 31, 2020
app/models/manageiq/providers/kubernetes/container_manager_mixin.rb
Outdated
Show resolved
Hide resolved
skateman
commented
Jul 31, 2020
app/models/manageiq/providers/kubernetes/container_manager_mixin.rb
Outdated
Show resolved
Hide resolved
skateman
force-pushed
the
ddf-forms-adjust
branch
3 times, most recently
from
July 31, 2020 13:06
111bce6
to
59c2dbd
Compare
skateman
force-pushed
the
ddf-forms-adjust
branch
from
July 31, 2020 13:20
59c2dbd
to
3e67e19
Compare
agrare
force-pushed
the
ddf-forms-adjust
branch
from
August 3, 2020 14:47
2edc625
to
b54260e
Compare
skateman
commented
Aug 6, 2020
app/models/manageiq/providers/kubernetes/container_manager_mixin.rb
Outdated
Show resolved
Hide resolved
skateman
commented
Aug 6, 2020
app/models/manageiq/providers/kubernetes/container_manager_mixin.rb
Outdated
Show resolved
Hide resolved
skateman
changed the title
[WIP] Adjusted DDF schema and credentials validation
Adjusted DDF schema and credentials validation
Aug 6, 2020
agrare
force-pushed
the
ddf-forms-adjust
branch
from
August 6, 2020 12:44
91a10d4
to
6391c54
Compare
Checked commits skateman/manageiq-providers-kubernetes@3e67e19~...6391c54 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
I guess this is good to go then 👍 |
@gtanzillo can you review since I have some commits in here now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make this form work, I had to do some tradeoffs:
default_value_for
in theContainerManagerMixin
prevents the usage ofcreate_from_params
so I deleted it..create_from_params
with the replication of the same data among endpoints. However, I'd rather see the provider using just the single authentication instead.authentications
if there's no token change. This can cause all authentications to be deleted upon an edit without a token change. In order to avoid this, I redefined the#edit_with_params
to make sure that allauthentications
exist for all theendpoints
. Again, this would be much easier if we could just use a single auth instead of copying the existing one N times.Detect
button will be able to copy these values on-demand.Detect
button doesn't work yet, there's no API endpoint for itand there's a styling issue that I'm trying to fixValidation is only working for the default endpoint and partially for kubevirt. The other endpoints need to have context-free methods than can work with the params I am sending. Kubevirt is using the same validation as the default endpoint, but it doesn't actually detect if the given token allows access to the kubevirt features.Parent issue: ManageIQ/manageiq#18818