Fixing the navigation logic and Angular controllers for Middleware provider #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jiri-Kremser Cannot apply the following label because they are not recognized: technical bug |
… and m. server group the own show partial is used (with angular controller initialization etc.)
…necessary now, when the own show logic is used.
jkremser
force-pushed
the
middleware-show-fix
branch
from
3206bac to
b7bd3f7
Compare
|
The loggic followed by the fix is correct for sure. 2 issues:
|
|
Checked commits jkremser/manageiq-ui-classic@f295dfa~...b7bd3f7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Checked all screens which were not functional before this fix, everything seems to be working fine. |
|
Gentlemen, I accept your promise that there will be tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup on this PR #687
I have created another PR for tests #693 the tests can go later, this should be merged relatively soon, because it blocks couple of people.
bz: https://bugzilla.redhat.com/show_bug.cgi?id=1430831
@miq-bot add_label bug, middleware
@martinpovolny could you please review?
@miq-bot assign @martinpovolny