More tests for middleware controllers #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkremser
force-pushed
the
controller-tests
branch
from
d9c6292 to
08d6411
Compare
|
for the nested lists, please use this: |
jkremser
force-pushed
the
controller-tests
branch
from
08d6411 to
6108e82
Compare
jkremser
changed the title
|
Checked commits jkremser/manageiq-ui-classic@6108e82~...7541a41 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@martinpovolny I finally, found some time to finish this one. Pls take a look, no rush :) |
|
@miq-bot add_label middleware |
|
@miq-bot assign @h-kataria |
|
👍 This is the way to go, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more specs for these middleware controllers:
It tests whether the nested entities were correctly rendered and if there are some special partials like angular popups, we test if the partial was rendered.
@miq-bot add_label technical debt, test