Compare - remove dead compare_set_base, {compare,drift}_matches, @base #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`compare_matches` is only called from `compare_set_base`. `compare_set_base` and `drift_matches` are never called. `@base` is no longer useful, since `compare_set_base` is the only method to save something useful there
only ever saved to session and restored from there
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/3bef4264c94a9f1aa3618696e0ae75f8a712b836~...dd7bb94c053a37f2adbe3c725adf9ceed72ad6cd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compare_matchesis only called fromcompare_set_base.compare_set_baseanddrift_matchesare never called.@baseis no longer useful, sincecompare_set_baseis the only method to save something useful there