Jasmine - upgrade to 3.4.0, use chrome headless backend

[himdel]

Right now, it looks like 9 out of the last 17 travis runs on master failed on spec:javascript:

* Listening on tcp://0.0.0.0:41063
Use Ctrl-C to stop

Waiting for jasmine server on 41063...
jasmine server started

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

Attempting to fix that.

The actual failure comes from phantomjs sometimes not managing to load the page, failing with:

ReferenceError: Can't find variable: SAFE_CLOSING

  undefined:18 in exports

(details in #5432)

Which is rather non-specific.

But, changing the backend from phantomjs to chrome headless fixes that (details in #5433).

The first jasmine gem version with support for chrome headless is 3.4.0 (also, the current latest),
so upgrading to that.

We had to fix the version to 2.5 when 2.6 came out, in #1148, but I don't see any info on why it failed, and .. it doesn't seem to fail now.

---

Jasmine 3.4.0 is a bit different in that it tries to run tests in random order by default. Leading to many failures (between 8 and 30ish) in our tests.

So, hacking the rake environment jasmine task to also output Please open http://localhost:8888/?random=false so that people get it right locally.

I also had to remove one random test, but it was one that was testing that the value it set was set, so, meh :).

Also had to add 2 test-only assets to the precompile list, as jasmine 3* fails trying to load non-precompiled assets.

This also means we're no longer testing our code in an old-browser-like environment.

[himdel]

@miq-bot add_label wip

[miq-bot]

Some comments on commits https://github.com/himdel/manageiq-ui-classic/compare/7338e9b0ea7f748b15f075d4110bb83647e21bfb~...3896880a51f35097c56b579358bd30fccca27f55

Rakefile

• ⚠️ - 38 - Detected puts. Remove all debugging statements.
• ⚠️ - 39 - Detected puts. Remove all debugging statements.
• ⚠️ - 40 - Detected puts. Remove all debugging statements.

[miq-bot]

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/7338e9b0ea7f748b15f075d4110bb83647e21bfb~...3896880a51f35097c56b579358bd30fccca27f55 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 3 offenses detected

Rakefile

• ❗ - Line 43, Col 3 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

spec/javascripts/support/jasmine_helper.rb

• ❗ - Line 16, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 17, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

[himdel]

@miq-bot remove_label wip