Move jasmine dependency from manageiq, force 2.5.2 #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmine 2.6.0 came out, breaking JS specs - we need to force 2.5* for now aand the dependency was still in manageiq, moving to ui-classic. (The core dependency is because jasmine-core is the actual jasmine, but jasmine 2.5 depends on jasmine-core >2.5 <3.0 meaning it would pick up 2.6 anyway without this.)
This was referenced Apr 25, 2017
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/9d023c2c2de48ef2f8e8f5d20c5614a87a755574 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Apr 25, 2017
Move jasmine dependency from manageiq, force 2.5.2 (cherry picked from commit f6bff09)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jasmine 2.6.0 came out, breaking JS specs - we need to force 2.5* for now
and the dependency was still in manageiq, moving to ui-classic.
(The core dependency is because jasmine-core is the actual jasmine, but jasmine 2.5 depends on jasmine-core >2.5 <3.0 meaning it would pick up 2.6 anyway without this.)
This is the second part of ManageIQ/manageiq#14870 .. but this time, the UI PR needs to be merged first. (Euwe version in ManageIQ/manageiq#14871.)