Use timeline listnav only for dashboard controller

[ZitaNemeckova]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1670550

Introduced by #3827 so this PR can not reintroduce toolbar with Configuration,...

Steps to test:

• make sure Cloud Intel -> Timeline still has a timeline tree in listnav
• for Availability Zones, Containers, Container Groups, Container Nodes, Container Pods, Container Projects, Clusters/Deployment Roles, Hosts/Nodes, Cloud Providers, Infra Providers, Container Providers select one of items and go to its summary page and Monitoring -> Timelines -> see that listnav is the same as in summary page and toolbar has only Back button
• all things in listnav redirects correctly after clicking

Before:

After:

@miq-bot add_label bug, hammer/yes

Having this issue resolved would save me tons of time.

[miq-bot]

Checked commits ZitaNemeckova/manageiq-ui-classic@990950f~...d7af2f9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
12 files checked, 0 offenses detected
Everything looks fine. 👍

[martinpovolny]

This is an ugly place. We moved this pasta to a separate file and limited the branching a bit in the past. But what is really needed to limit regressions here in the future is to have the listnav logic split based on the controller. But for that we need a good understanding of what has to be rendered where (which is hard to get from the pasta) and far more tests... ...or we create even more regressions :-(

👍 for the new tests that your wrote 💯

It's funny that a miniature test coverage drop is reported by the CC here. I suspect that the coverage measurement has limited value.

[simaishi]

Hammer backport details:

$ git log -1
commit 91755d7d6f4feaf53e27d087901b17fb15338c02
Author: Martin Povolny <[email protected]>
Date:   Sat Feb 2 09:20:13 2019 +0100

    Merge pull request #5218 from ZitaNemeckova/add_timeline_listnav
    
    Use timeline listnav only for dashboard controller
    
    (cherry picked from commit bc27d17e8a464bad85815b0551b3f250464e7753)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1686016