Timeline menu

[martinpovolny]

Put the Right Menu into Remove menu from the Timeline screen.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1536097

Changes:

• remove one level of nesting in ToolbarChooser (so that we can actually read the condition)
• split method button in EmsCommon (the method was already a if/else/case branching with methods calls, but somehow people started adding in-line code again 😢 😭 )
• remove extra code from timeline_pressed
• combination of @layout and @last_action then causes the correct toolbar: timeline_center to be rendered.
• make the redirect in update_ems_button_cancel more robust (will default to show when given action does not exist).

Steps for Testing/QA

1. Have a provider (tested with vSphere infra)
2. Open the provider's details
3. Select Monitoring/Timelines
4. Inside Timelines, select Configuration/Edit this XYZ provider this is no longer possible with this PR
5. Inside the edit dialog, press Cancel

[miq-bot]

Checked commits martinpovolny/manageiq-ui-classic@8781604~...0c3eca4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 1 offense detected

app/helpers/application_helper/toolbar_chooser.rb

• ❗ - Line 537, Col 16 - Style/YodaCondition - Reverse the order of the operands 'show_list' == @lastaction.