Use onchange only for radio buttons #5097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZitaNemeckova
force-pushed
the
fix_my_error_in_miq_uis_bindings
branch
from
4fcfd0f to
ae69958
Compare
|
@himdel what do you think? |
ZitaNemeckova
force-pushed
the
fix_my_error_in_miq_uis_bindings
branch
from
ae69958 to
fd80afa
Compare
|
👍 but we should still disable the old behaviour for radio buttons |
|
@himdel done |
|
Checked commits ZitaNemeckova/manageiq-ui-classic@fd80afa~...f72005a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM, limits the scope of #4252 only to radio buttons, and disables the old behaviour for those. (checkboxes are already handled that way via Looks like the only use of radios with miq_observe is in:
|
simaishi
pushed a commit
that referenced
this pull request
Feb 6, 2019
…indings Use onchange only for radio buttons (cherry picked from commit 4680abf) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1672696
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656003
Introduced by #4252
@miq-bot add_label gaprindashvili/yes, hammer/yes, bug