-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use onchange as well as onfocus for radio buttons #4252
Use onchange as well as onfocus for radio buttons #4252
Conversation
@AparnaKarve please have a look. It's MacOS specific issue. Thanks :) |
Checked commit ZitaNemeckova@04c8cb9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
ping @lpichler : can you, please, test this? (in case @AparnaKarve is too busy) Thx! |
@ZitaNemeckova I could reproduce the error and can confirm that Save is enabled in Firefox after changing the Inventory type from Although, changing it from ... given that it is an old non-angular form, I think the current behavior with the fix is quite OK |
@ZitaNemeckova is this ready to be merged,..if yes, who can do that. |
Use onchange as well as onfocus for radio buttons (cherry picked from commit eff0299) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1598873
Gaprindashvili backport details:
|
Causes https://bugzilla.redhat.com/show_bug.cgi?id=1656003 Thanks to this change, every single element with miq-observe will now send change events twice. EDIT: fixed in #5097 |
Firefox on MacOS doesn't fire
onfocus
when radio button is clicked. And it's by design as seen here here here so addingonchange
to do the same asonfocus
.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1594714
How to reproduce:
Before:
Save/Reset buttons disabled.
Change to Inventory not saved.
After:
Save/Reset buttons enabled
Change to Inventory saved.
@miq-bot add_label bug, blocker, gaprindashvili/yes