Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in perpage_key for GTL types #5036

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Fix regression in perpage_key for GTL types #5036

merged 1 commit into from
Dec 5, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Dec 4, 2018

Regression caused by #4749, the dbname should've been @gtl_type.

@miq-bot add_reviewer @PanSpagetka
@miq-bot add_label bug, hammer/yes

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1655539

@miq-bot miq-bot requested a review from PanSpagetka December 4, 2018 12:47
@skateman skateman force-pushed the perpage-key-regression branch from da5d869 to 4e89155 Compare December 4, 2018 13:08
@miq-bot
Copy link
Member

miq-bot commented Dec 4, 2018

Checked commit skateman@4e89155 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@JPrause
Copy link
Member

JPrause commented Dec 4, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Dec 4, 2018
PanSpagetka
PanSpagetka approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@PanSpagetka PanSpagetka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it works, even for reports 👍

@skateman
Copy link
Member Author

skateman commented Dec 5, 2018

@miq-bot assign @mzazrivec

@mzazrivec mzazrivec added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 5, 2018
@mzazrivec mzazrivec merged commit 6fe225c into ManageIQ:master Dec 5, 2018
@skateman skateman deleted the perpage-key-regression branch December 5, 2018 09:31
simaishi pushed a commit that referenced this pull request Dec 6, 2018
@mzazrivec @simaishi
Merge pull request #5036 from skateman/perpage-key-regression
59534d8 
Fix regression in perpage_key for GTL types

(cherry picked from commit 6fe225c)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1655539
@simaishi
Copy link
Contributor

simaishi commented Dec 6, 2018

Hammer backport details:

$ git log -1
commit 59534d85b8df5800adb8cc433c17a45744d98973
Author: Milan Zázrivec <[email protected]>
Date:   Wed Dec 5 10:29:01 2018 +0100

    Merge pull request #5036 from skateman/perpage-key-regression
    
    Fix regression in perpage_key for GTL types
    
    (cherry picked from commit 6fe225cc9c40b5046d5301437893f032136c5782)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1655539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PanSpagetka PanSpagetka PanSpagetka approved these changes

Assignees

@mzazrivec mzazrivec

Labels
blocker bug compute/infrastructure hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skateman @miq-bot @JPrause @simaishi @PanSpagetka @mzazrivec