Use report default options for Report screens #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label hammer/yes |
skateman
suggested changes
Oct 9, 2018
| @@ -1343,6 +1343,7 @@ def get_view_process_search_text(view) | |||
| end | |||
|
|
|||
| def perpage_key(dbname) | |||
| return :reports if dbname == "miqreportresult" | |||
There was a problem hiding this comment.
I don't really like this 😥 could you at least convert it into a case?
PanSpagetka
force-pushed
the
bz-1616201
branch
2 times, most recently
from
a77708c to
a487960
Compare
|
ping @skateman |
PanSpagetka
force-pushed
the
bz-1616201
branch
3 times, most recently
from
12527e2 to
5ca4233
Compare
|
Checked commits PanSpagetka/manageiq-ui-classic@fb2ae5a~...5ca4233 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Oct 16, 2018
Use report default options for Report screens (cherry picked from commit 7edf695) https://bugzilla.redhat.com/show_bug.cgi?id=1616201
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports on Save Report screen, should use default item count per page which is set in My Settings for Reports.
@gtl_typevariable used from deriving the per page count only can begrid,tileorlistLinks [Optional]
https://bugzilla.redhat.com/show_bug.cgi?id=1616201
Steps for Testing/QA [Optional]
All Saved Reports, check the paginator - value remains 20.