-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace virtualization_tab
references with kubevirt_tab
#5001
Conversation
In general, I don't think that we should be using a provider specific term in the UI. Kubevirt is a specific type of virtualization provider. (I do understand that this particular form is not pluggable, but I'm not sure this moves anything in the right direction 😕 ) |
Checked commit AparnaKarve@2cfb878 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
@Fryguy Agreed! but this patch is simply fixing a mistake and addresses a BZ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me + verified locally (including enabling / disabling) the virtualization tab at new/update provider dialogs.
Replace `virtualization_tab` references with `kubevirt_tab` (cherry picked from commit faf462e)
Hammer backport details:
|
Thanks for fixing this! :) Long term, we really need that logic to come from providers, but, that's long term. |
@himdel Thanks - could not agree more! |
Replace
virtualization_tab
references withkubevirt_tab
-- this was missed in 583d776https://bugzilla.redhat.com/show_bug.cgi?id=1650410
Before (shows the tiny and almost invisible tab) -
After (no tiny/invisible tabs) -
With
Virtualization
disabled -With
Virtualization
set toKubevirt
-https://bugzilla.redhat.com/show_bug.cgi?id=1650410