Rename tabs in the haml to match current tab in the controller scope #4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$scope.currentTab needs to always match the tab name passed in from the haml in order to make sure that the validation is done correctly when the "Enter" key is pressed
'container_metrics' is actually a proper name for a tab to differentiate it from the RHV metrics tab. So ideally 'container_metrics' tab name should be retained, however this would mean a whole bunch of other changes from the backend side, since the backend expects cred_type to be 'metrics' (as opposed to 'container_metrics') Therefore, unfortunately we have to rename the tab to 'metrics' . This is probably an easier change than changing the backend rails controller code.
|
@miq-bot add_label bug,hammer/yes |
|
@masayag Thank you for testing this. @miq-bot assign @h-kataria |
|
Checked commits AparnaKarve/manageiq-ui-classic@583d776~...bc783ed with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
simaishi
pushed a commit
that referenced
this pull request
Oct 26, 2018
…_tab Rename tabs in the haml to match current tab in the controller scope (cherry picked from commit 020f33c) https://bugzilla.redhat.com/show_bug.cgi?id=1609735 https://bugzilla.redhat.com/show_bug.cgi?id=1640304
|
Hammer backport details: |
|
Causes https://bugzilla.redhat.com/show_bug.cgi?id=1650410 (regression of https://bugzilla.redhat.com/show_bug.cgi?id=1550405, previously fixed in #3511) |
|
My first guess is something was probably missed in the first commit 583d776 while renaming virtualization tab to kubevirt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted Container Provider tab names so that they are consistent with what's specified in the haml and the value passed to the angular controller when Validate is clicked.
This is also a continuation of work for this PR - #4768
https://bugzilla.redhat.com/show_bug.cgi?id=1609735
https://bugzilla.redhat.com/show_bug.cgi?id=1640304