Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bottom tooltip placement for notifications in the drawer #4821

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Fix bottom tooltip placement for notifications in the drawer #4821

merged 1 commit into from
Oct 25, 2018

Conversation

skateman
Copy link
Member

This is a regression caused by #4057 and a bug in angular-bootstrap as it does not behave for all prefixes as it should.

Before:
screenshot from 2018-10-24 16-02-27

After:
screenshot from 2018-10-24 16-04-19

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1635597
@miq-bot add_label bug
@miq-bot add_reviewer @epwinchell
@miq-bot add_reviewer @himdel

@miq-bot miq-bot added the bug label Oct 24, 2018
@miq-bot miq-bot requested review from epwinchell and himdel October 24, 2018 14:08
@miq-bot
Copy link
Member

miq-bot commented Oct 24, 2018

Checked commit skateman@3155310 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

himdel
himdel approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) the prefix code in ui-bootstrap is weird :)

epwinchell
epwinchell approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@epwinchell epwinchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good.

@mzazrivec mzazrivec self-assigned this Oct 25, 2018
@mzazrivec mzazrivec added this to the Sprint 98 Ending Nov 5, 2018 milestone Oct 25, 2018
@mzazrivec mzazrivec merged commit cb080ec into ManageIQ:master Oct 25, 2018
@skateman skateman deleted the drawer-tooltip-fix branch October 25, 2018 09:56
simaishi pushed a commit that referenced this pull request Oct 25, 2018
@mzazrivec @simaishi
Merge pull request #4821 from skateman/drawer-tooltip-fix
519f849 
Fix bottom tooltip placement for notifications in the drawer

(cherry picked from commit cb080ec)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1635597
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 519f8498c54399cd055e86ba7edf2ad972342adb
Author: Milan Zázrivec <[email protected]>
Date:   Thu Oct 25 11:49:54 2018 +0200

    Merge pull request #4821 from skateman/drawer-tooltip-fix
    
    Fix bottom tooltip placement for notifications in the drawer
    
    (cherry picked from commit cb080ecec63f95066dc37f7dcc8c24116c895679)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1635597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epwinchell epwinchell epwinchell approved these changes

@himdel himdel himdel approved these changes

Assignees

@mzazrivec mzazrivec

Labels
bug hammer/backported notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skateman @miq-bot @simaishi @himdel @epwinchell @mzazrivec