Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix all angular-bootstrap directives with uib- #4057

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Jun 5, 2018

Prefixing all the things, based on this guide so we can update to the latest angular-bootstrap.

@miq-bot add_reviewer @himdel
@miq-bot add_label gaprindashvili/no, technical debt

@miq-bot
Copy link
Member

miq-bot commented Jun 5, 2018

Checked commit skateman@94fe03e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
12 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@@ -21,7 +21,7 @@
:remote => true,
"data-method" => :post)
- else
= link_to(tab[1], :action => 'change_tab', :tab => tab[0], :id => @tab_id)
= link_to(tab[1], :action => 'change_tab', 'uib-tab' => tab[0], :id => @tab_id)
Copy link
Contributor

@himdel himdel Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 more:

app/views/layouts/_tabs.html.haml
17:                   :tab    => tab[0],
30:                     :tab    => tab[0],
39:                     :tab    => tab[0],

EDIT: never mind, those are link_to

@himdel himdel added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 11, 2018
@himdel himdel merged commit 30c870a into ManageIQ:master Jun 11, 2018
@skateman skateman deleted the uib-prefix branch June 11, 2018 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants