[WIP] user-management react module

[Hyperkid123]

This should not be included to Hammer release.

This PR replaces the whole user section in access control with React components.

Changes

• State management via redux
• Client routing using react-router (also connected to tree-view-controller and toolbars)
• Using miq API where possible
• Data lazy loading (no server roundtrip)

TO-DO

• use bulk assignment for tagging users Enable bulk assignment of tags for users manageiq-api#459
• lots of specs
• code cleanup
• disable tree navigation while adding/editing/tagging user
• hide toolbar while adding/editing/tagging user
• delete dead code from OpsController and OpsRbac
• add prop-type checking
• add actions to group and role links in user detail
• add current tags list to user detail
• filter tag categories with no entries
• update react-ui-components version after Rbac components fix react-ui-components#77 , Allow custom sorting on generic table. react-ui-components#78, Fix enable/disable buttons for rbac users form. react-ui-components#88 and Added searching to users form group select component. react-ui-components#87 are merged
• add flash messages on events
• add error handling on server response
• add pagination to user table depends on Allow custom sorting on generic table. react-ui-components#78
• w8 for Add custom_button_events subcollection for users, tenants and groups manageiq-api#464 to get merged
• add is admin checking: Add available product features local storage. #4756

EDIT: most of the PR are test related files i did not write 3k+ lines of code

[Hyperkid123]

@miq-bot add_reviewer @karelhala
@miq-bot add_reviewer @martinpovolny
@miq-bot add_reviewer @himdel
@miq-bot add_reviewer @dclarizio
@miq-bot add_reviewer @apagac

[Hyperkid123]

@miq-bot add_label react

[miq-bot]

@Hyperkid123 'apagac' is an invalid reviewer, ignoring...

[himdel]

missing ()?

[Hyperkid123]

nice catch!

[Hyperkid123]

@ZitaNemeckova @lpichler

[lpichler]

entries.includes(:tag) to avoid N+1 queires and you can use . notation { :value => entry.id,...` to access attributes.

thanks

[lpichler]

I believe that this could be done in query
Classification.where(:ids => params[:ids]).includes(:tags)....

I see similar pattern in such queries so maybe you will find how to unify it to one method and put it on model.

[Hyperkid123]

@dclarizio @martinpovolny @lpichler i think it is ready for some clicking in the UI. You just need to add this PR ManageIQ/manageiq-api#464 to your API plugin.

[miq-bot]

Checked commits Hyperkid123/manageiq-ui-classic@ad51220~...27ee4e9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
14 files checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

[Hyperkid123]

@dclarizio @himdel ok after a lot debugging hacking and discussing, we (me and @himdel) have decided that introducing client-side routing at this stage will create more problems than we have right now. Until other major changes are done to the app, adding client side routing to existing parts of the ui is not very beneficial. There is a ton of interactions between trees, toolbars and other that make this unnecessarily complicated (the code shows it) and not very maintainable.

I will extract all the components i have made simply put them inside the layout without the routing.