-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom_button_events subcollection for users, tenants and groups #464
Add custom_button_events subcollection for users, tenants and groups #464
Conversation
@skateman if a feature is marked as a hidden feature it is not displayed in the features tree but role_allows call returns true for the hidden features, in this case since we are not making role_allows call it should work. |
@h-kataria thanks, that's great, then we would need to specify somehow that this feature is for admins and super admins only. Is there a way to do so? |
f93814c
to
18f67cb
Compare
@miq-bot assign @abellotti |
- :subcollection | ||
:verbs: *g | ||
:klass: CustomButtonEvent | ||
:subcollection_actions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need subresource_actions
for get
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not completely familiar what that would allow us, can you please help me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, subcollection_actions
get
allows get /api/users/:id/custom_button_events
, but you would need subresource_actions
get
to allow get /api/users/:id/custom_button_events/:id
. Is that correct @abellotti?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdunne we don't need those, this feature is an admin-only debug thing
18f67cb
to
db00209
Compare
db00209
to
80e6115
Compare
Checked commit skateman@80e6115 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@bdunne what is the progress with this PR? |
@Hyperkid123 unleash |
As we discussed with @Hyperkid123 and @h-kataria, the new API-driven react/redux-based RBAC UI should include the custom button events via the API instead of using nested resources.
@miq-bot add_label enhancement, gaprindashvili/no
cc @Hyperkid123 you can start working with this in your PR
https://bugzilla.redhat.com/show_bug.cgi?id=1634053