Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mislabeled Description field on the EmsCloud summary view #4532

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Fix mislabeled Description field on the EmsCloud summary view #4532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
703f042
Fix mislabeled Description field on the EmsCloud summary view
mansam Aug 21, 2018
8153e9a
Update EmsCloud textual summary spec to include description field
mansam Aug 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/helpers/ems_cloud_helper/textual_summary.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module EmsCloudHelper::TextualSummary
def textual_group_properties
TextualGroup.new(
_("Properties"),
%i(provider_region hostname ipaddress type port guid region keystone_v3_domain_id)
%i(description hostname ipaddress type port guid region keystone_v3_domain_id)
)
end

Expand Down Expand Up @@ -38,9 +38,9 @@ def textual_group_topology
#
# Items
#
def textual_provider_region
return nil if @record.provider_region.nil?
{:label => _("Region"), :value => @record.description}
def textual_description
return nil if @record.description.blank?
{:label => _("Description"), :value => @record.description}
end

def textual_region
Expand Down
2 changes: 1 addition & 1 deletion spec/helpers/ems_cloud_helper/textual_summary_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
orchestration_stacks
storage_managers
)
include_examples "textual_group", "Properties", %i(provider_region hostname ipaddress type port guid region keystone_v3_domain_id)
include_examples "textual_group", "Properties", %i(description hostname ipaddress type port guid region keystone_v3_domain_id)

include_examples "textual_group", "Status", %i(refresh_status refresh_date)

Expand Down