Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mislabeled Description field on the EmsCloud summary view #4532

Merged
merged 2 commits into from
Aug 24, 2018

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Aug 23, 2018

Fixes an apparent copy-paste error that resulted in the EmsCloud description field being labeled as "Region" and using an erroneous display condition.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1392342

region_description_fix

@mansam mansam force-pushed the fix-ems-cloud-textual-description branch from 2eda34b to 8153e9a Compare August 23, 2018 17:21
@miq-bot
Copy link
Member

miq-bot commented Aug 23, 2018

Checked commits mansam/manageiq-ui-classic@703f042~...8153e9a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@mzazrivec mzazrivec self-assigned this Aug 24, 2018
@mzazrivec mzazrivec added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 24, 2018
@mzazrivec mzazrivec merged commit ccca233 into ManageIQ:master Aug 24, 2018
@himdel
Copy link
Contributor

himdel commented Sep 13, 2018

Please note that description is not available on all Ems kinds, so this broke stuff :).

Fixed in #4638, please backport together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants