Removed data-miq_observe from drop down
#4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miqSelectPickerEvent is being called to observe botstrap dropdowns, having both observers causes double transactions to be sent upto server and causes an issue in UI randomly. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1601915 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1614437
|
Checked commit h-kataria@14d01e4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@skateman can you please test/review |
|
The fix looks good. Not sure what changed, if anything. The combination of data-miq_observe + miqSelectPickerEvent was never really supposed to be there. |
simaishi
pushed a commit
that referenced
this pull request
Aug 21, 2018
…transaction_fix Removed `data-miq_observe` from drop down (cherry picked from commit a46f071) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1615633 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1615632
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
miqSelectPickerEvent is being called to observe botstrap dropdowns, having both observers causes double transactions to be sent upto server and causes an issue in UI randomly.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1601915
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1614437
@himdel do you know why all of a sudden we are seeing these type of issues in UI with double transactions beings sent on drop downs, i recently fixed another one #4488
This issue does not happen always, but something to do with timings of transactions