Fixed to use bootstrap select event instead of UJS observer #4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using old leaftover UJS observers on the drop downs was causing form to send up multipe transaction when a selection was made in drop downs, causing other issues in the form. convert id to_i to make sure the comparison of is between same types Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1615853
|
Checked commit h-kataria@5c6044c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/controllers/catalog_controller.rb
|
|
This was merged while I was testing - looks good - also verified the fix in the UI. |
|
@h-kataria The BZ is marked for Gaprindashvili backport, but this PR is |
|
@simaishi fixed the label, i meant to add |
simaishi
pushed a commit
that referenced
this pull request
Sep 17, 2018
…wn_selection_fix Fixed to use bootstrap select event instead of UJS observer (cherry picked from commit 44601d4) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1618836
|
Gaprindashvili backport details: |
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Oct 29, 2018
Backport of ManageIQ#4488 broke the observer for Action order drop down. In ManageIQ#2482 use of compressed ids was removed from https://github.com/ManageIQ/manageiq-ui-classic/pull/2482/files#diff-10a8b10a2fee4a8ed7444f35479d9444L66 causing the observer and field name to not match. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1615853
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Oct 29, 2018
Backport of ManageIQ#4488 broke the observer for Action order drop down. In ManageIQ#2482 use of compressed ids was removed from https://github.com/ManageIQ/manageiq-ui-classic/pull/2482/files#diff-10a8b10a2fee4a8ed7444f35479d9444L66 causing the observer and field name to not match. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1618836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using old leftover UJS observers on the drop downs was causing form to send up multipe transaction when a selection was made in drop downs, causing other issues in the form.
convert id to_i to make sure the comparison of is between same types
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1615853
@dclarizio Attached a video in the BZ that verifies the fix.
@lgalis can you please review/verify fix.