[GAPRINDASHVILI] Support all service types for dialog buttons #4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit eclarizio@5b2d695 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/services/dialog_local_service_spec.rb
|
|
@h-kataria @dclarizio please review |
martinpovolny
suggested changes
Aug 8, 2018
There was a problem hiding this comment.
@eclarizio : I see only test changes in this PR. Is that intended? In the original PR I see more changes.
|
@martinpovolny this was created to fix Travis failure caused by backporting #4418 |
martinpovolny
approved these changes
Aug 8, 2018
|
@martinpovolny thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport for #4418.
https://bugzilla.redhat.com/show_bug.cgi?id=1611527
@miq-bot assign @simaishi