Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all service types for dialog buttons #4418

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

eclarizio
Copy link
Member

An extension of #4404, this adds all the Service class's descendants to the list of object types that are supported by custom buttons.

https://bugzilla.redhat.com/show_bug.cgi?id=1611527

@miq-bot add_label gaprindashvili/yes, bug, blocker, services, angular dialogs
@miq-bot assign @h-kataria

/cc @tinaafitz

@miq-bot
Copy link
Member

miq-bot commented Aug 6, 2018

Checked commit eclarizio@5eba11a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@h-kataria
Copy link
Contributor

looks good

@h-kataria h-kataria added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 6, 2018
@h-kataria h-kataria merged commit 14931c2 into ManageIQ:master Aug 6, 2018
simaishi pushed a commit that referenced this pull request Aug 6, 2018
Support all service types for dialog buttons
(cherry picked from commit 14931c2)

https://bugzilla.redhat.com/show_bug.cgi?id=1612062
@simaishi
Copy link
Contributor

simaishi commented Aug 6, 2018

Gaprindashvili backport details:

$ git log -1
commit 2b082a1754eb30a439773af6c578f5bbc6967b19
Author: Harpreet Kataria <[email protected]>
Date:   Mon Aug 6 14:18:24 2018 -0400

    Merge pull request #4418 from eclarizio/BZ1611527
    
    Support all service types for dialog buttons
    (cherry picked from commit 14931c230df0cffe8f43af60206bf2e523dcb247)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1612062

@simaishi
Copy link
Contributor

simaishi commented Aug 6, 2018

@eclarizio Please take a look at Travis failure in G-branch:
https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/412872375

An error occurred while loading ./spec/services/dialog_local_service_spec.rb.
Failure/Error:
  include_examples "DialogLocalService#determine_dialog_locals_for_custom_button return value",
                   "service", "services", "/service/explorer"
ArgumentError:
  Could not find shared examples "DialogLocalService#determine_dialog_locals_for_custom_button return value"

@eclarizio
Copy link
Member Author

@simaishi Ah, it's because this PR (#4374) introduced the shared_examples and isn't on the list of things to backport.

It will need everything from lines 43 through 61 from here.

@simaishi
Copy link
Contributor

simaishi commented Aug 6, 2018

@eclarizio Based on the BZ, #4374 will not be backported to Gaprindashvili branch. Can you please create a PR to fix the Travis error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants