-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all service types for dialog buttons #4418
Conversation
Checked commit eclarizio@5eba11a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
looks good |
Support all service types for dialog buttons (cherry picked from commit 14931c2) https://bugzilla.redhat.com/show_bug.cgi?id=1612062
Gaprindashvili backport details:
|
@eclarizio Please take a look at Travis failure in G-branch:
|
@eclarizio Based on the BZ, #4374 will not be backported to Gaprindashvili branch. Can you please create a PR to fix the Travis error? |
An extension of #4404, this adds all the
Service
class's descendants to the list of object types that are supported by custom buttons.https://bugzilla.redhat.com/show_bug.cgi?id=1611527
@miq-bot add_label gaprindashvili/yes, bug, blocker, services, angular dialogs
@miq-bot assign @h-kataria
/cc @tinaafitz