Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code related to Tenant #4011

Merged
merged 6 commits into from
May 31, 2018

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented May 31, 2018

Fix broken master tests that failed after ManageIQ/manageiq#17360 .

Removing all methods that aren't needed after a conversion from old form to Angularjs form and using API #1544 . No new tests as same things are tested in js specs.

@miq-bot add_label bug, gaprindashvili/yes, test, technical debt

@miq-bot
Copy link
Member

miq-bot commented May 31, 2018

Checked commits ZitaNemeckova/manageiq-ui-classic@100c7a5~...4eb6369 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@ZitaNemeckova
Copy link
Contributor Author

@h-kataria please have a look, thanks :)

@h-kataria h-kataria self-assigned this May 31, 2018
@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria added this to the Sprint 87 Ending Jun 4, 2018 milestone May 31, 2018
@h-kataria h-kataria merged commit fbd89d2 into ManageIQ:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants