Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix textual summary display in tenants. #4009

Merged
merged 2 commits into from
May 31, 2018

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented May 31, 2018

ping @ZitaNemeckova

  • fix a regression causes by the TextualSummary componentization PR
  • fix broken formatting

FIXME

  • there are more issues probably related to the use of API and angular in editing tennants. Namely the left tree disappears on {new,edit}/save or edit/cancel. There's a whole page reload, that should not be....

@ZitaNemeckova
Copy link
Contributor

Configuration -> Access Control -> click on a tenant
Before:
screen shot 2018-05-31 at 2 12 28 pm
After:
It works correctly.

Tested in UI. LGTM 👍

@miq-bot
Copy link
Member

miq-bot commented May 31, 2018

Checked commits martinpovolny/manageiq-ui-classic@456420e~...8d470a4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@martinpovolny martinpovolny changed the title Fix textual summary display in tennants. Fix textual summary display in tenants. May 31, 2018
@ZitaNemeckova
Copy link
Contributor

Tested second commit in UI.
Before:
screen shot 2018-05-31 at 3 37 52 pm

After:
screen shot 2018-05-31 at 3 38 20 pm

LGTM 👍

@himdel himdel self-assigned this May 31, 2018
@ZitaNemeckova
Copy link
Contributor

  1) OpsController::Tenants #tenant_set_record_vars sets value of parent & divisible fields for new record
     Failure/Error: expect(tenant.parent.id).to eq(@tenant.id)
     
       expected: 84000000001212
            got: 84000000001211
     
       (compared using ==)
     # ./spec/controllers/ops_controller/ops_rbac_spec.rb:277:in `block (4 levels) in <top (required)>'

Test failure is unrelated to this PR.

@himdel
Copy link
Contributor

himdel commented May 31, 2018

Merging in spite of failing travis, as this is needed for testing the actual travis fix :). (#4011)

@himdel himdel merged commit 8d54870 into ManageIQ:master May 31, 2018
@himdel himdel added this to the Sprint 87 Ending Jun 4, 2018 milestone May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants