Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store console popups in session #3842

Merged
merged 1 commit into from
May 3, 2018
Merged

Do not store console popups in session #3842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/controllers/application_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1872,6 +1872,9 @@ def remember_tab

url = URI.parse(request.url).path

# Do not include console popup windows urls. Only urls from the main UI are supported.
return if %w(launch_vmware_console launch_html5_console).any? { |i| url.include?(i) }

section.parent_path.each do |sid|
session[:tab_url][sid] = url
end
Expand Down