Do not store console popups in session #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
reviewed
Apr 26, 2018
| @@ -1872,6 +1872,10 @@ def remember_tab | |||
|
|
|||
| url = URI.parse(request.url).path | |||
|
|
|||
| if (url.include? "launch_vmware_console") || (url.include? "launch_html5_console") | |||
There was a problem hiding this comment.
What do you think about?
return if %w(launch_vmware_console launch_html5_console).any? { |i| url.include?(i) }This would also solve the rubocop issues...
There was a problem hiding this comment.
Also a comment about why do we need this line would be nice.
There was a problem hiding this comment.
Thanks, I will apply your suggestions
|
Checked commit evertmulder@c97a3ff with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot assign @martinpovolny |
|
gaprindashvili? |
|
I think we need a BZ for that. |
|
@miq-bot add_label gaprindashvili/yes, fine/yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console popup windows update the user session data (session[:tab_url][sid]). This data is used falsely by the dashboard_controller.rb in redirect_to_remembered, method that tries to redirect the console in the main ManageIQ UI. This leads to a exception in the manageiq ui. See #3833.
This PR is a really ugly fix that mitigates the issue for VMWARE WebMKS and HTML5 console. I think this PR must be improved to fix it for all possible popup windows... Suggestions are welcome.
Links