Remove specific name for provider region row for Google provider #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google provider have provider_region set to nil so it will never have provider_region row displayed so removing specific name of that row for Google provider
|
Checked commit ZitaNemeckova@9073596 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM, removes provider specific logic 👍 :) (waiting for travis) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google provider have
provider_regionset tonilso it will never have provider region row displayed so removing specific name of that row for Google provider ✂️It's not effecting anything just a dead code.Change introduced in ManageIQ/manageiq-providers-google#52
@miq-bot add_label technical debt, gaprindashvili/no