Remove region support

[tumido]

Remove regions completely from GCE for now. They were used only for ems descriptions - incorrectly, since the provider operates across regions.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1433062
Related: ManageIQ/manageiq#17088

@miq-bot add_label bug, gaprindashvili/yes, refactoring

[bronaghs]

Looks like there are some specs around regions here:

manageiq-providers-google/spec/models/manageiq/providers/google/cloud_manager_spec.rb

Line 52 in 8288913

it "moves the network_manager to the same zone and provider region as the cloud_manager" do

[bronaghs]

@tumido - is this needed?

[tumido]

@bronaghs Why should we keep it there? GCE has currently no usecase for regions at all.

[bronaghs]

Im referring to line 21, Im implying it looks like it isnt.

[tumido]

Ah, I see, sorry.

Well, this will keep the manager zones in sync and I assume we want that. Also as a sideeffect it would sync the provider_region, sure. Though if it's already nil, it's nil for both managers and nothing really happens.

The other way would be to define a new before_update rule, which would sync only the zone. And also new before_create rule, since :ensure_managers uses :ensure_managers_zone_and_provider_region internally. I just thing leaving it there is harmless. What do you think?

[bronaghs]

@tumido - Given that these methods have such short implementations, I think it would be worthwhile to override them to keep things clean.

[tumido]

Ok, the spec is pointless (the region part). GCE spans across all regions so there's no point in placing it in one region specifically and checking if it works. It does work, cause there's a restriction for it, but such change has no real impact on provider. I'll remove that from the spec, thanks for pointing that out 👍

[bronaghs]

Looks like region should be removed from here:

manageiq-providers-google/spec/models/manageiq/providers/google/cloud_manager/refresher_spec.rb

Line 5 in 78f85fc

@ems = FactoryGirl.create(:ems_google, :zone => zone, :provider_region => "us-central1")

[tumido]

Good catch with the Factory, I'll remove that. I'll also remove it from core factories at:

• ext_management_system.rb#L295
• ext_management_system.rb#L310

Sounds good?

[bronaghs]

sounds good @tumido

[miq-bot]

Checked commit tumido@630418c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🏆

[juliancheal]

LGTM 👍

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit f270e0ea449b5bedee905f85d07fc08f220ef3b0
Author: Bronagh Sorota <[email protected]>
Date:   Tue Mar 6 10:44:13 2018 -0500

    Merge pull request #52 from tumido/remove_regions_from_ems
    
    Remove region support
    (cherry picked from commit e91c9f6be0f33496d03646df2fe9b1aa8460ec53)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552305