Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Compliance Information #3419

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Add Compliance Information #3419

merged 1 commit into from
Apr 20, 2018

Conversation

CharlleDaniel
Copy link
Member

@CharlleDaniel CharlleDaniel commented Feb 16, 2018

This PR is able to :

  • Add the compliance group in the physical server's page.*
  • Fix the label group Firmware to Firmwares

compliance_table2

compliance_table

Dependes on : Lenovo's Provider PR 134 - Merged

@mzazrivec
Copy link
Contributor

@CharlleDaniel Please remove the pending core label once the provider PR is merged. Thanks.

@CharlleDaniel
Copy link
Member Author

@mzazrivec ok, thanks!

@miq-bot
Copy link
Member

miq-bot commented Mar 2, 2018

This pull request is not mergeable. Please rebase and repush.

@CharlleDaniel
Copy link
Member Author

@miq-bot remove_label unmergeable, pending core

@CharlleDaniel
Copy link
Member Author

@mzazrivec ping

@mzazrivec
Copy link
Contributor

@CharlleDaniel The PR has conflicts which need to be resolved.

@mzazrivec
Copy link
Contributor

@CharlleDaniel Can you also address the styling issues above please?

@miq-bot
Copy link
Member

miq-bot commented Apr 20, 2018

Checked commit https://github.com/CharlleDaniel/manageiq-ui-classic/commit/322a1b1670391d363d18a07ace9147994620aaae with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@CharlleDaniel
Copy link
Member Author

@mzazrivec done, thanks.

@mzazrivec mzazrivec added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 20, 2018
@mzazrivec mzazrivec merged commit f25cd79 into ManageIQ:master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants