Add compliance information to a server #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlleDaniel
force-pushed
the
add_compliance_information
branch
3 times, most recently
from
7c612c9 to
c8f246e
Compare
|
This pull request is not mergeable. Please rebase and repush. |
|
@CharlleDaniel can you rebase this PR? |
CharlleDaniel
force-pushed
the
add_compliance_information
branch
5 times, most recently
from
8d86983 to
d5f6d14
Compare
|
@agrare Could you review this PR please? |
CharlleDaniel
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
CharlleDaniel
force-pushed
the
add_compliance_information
branch
6 times, most recently
from
2734253 to
09010a6
Compare
CharlleDaniel
changed the title
|
@CharlleDaniel can you rebase this PR? |
CharlleDaniel
force-pushed
the
add_compliance_information
branch
from
09010a6 to
bf345c0
Compare
agrare
reviewed
Apr 18, 2018
| @@ -7,6 +7,8 @@ | |||
| VCR.insert_cassette("#{vcr_path}/mock_cabinet", options) | |||
| VCR.insert_cassette("#{vcr_path}/mock_config_patterns", options) | |||
| VCR.insert_cassette("#{vcr_path}/mock_switches", options) | |||
| VCR.insert_cassette("#{vcr_path}/mock_compliance_policy", options) | |||
|
|
|||
There was a problem hiding this comment.
@CharlleDaniel can you remove this line?
There was a problem hiding this comment.
yes, I can. Thanks
|
From my side this looks good, @rodneyhbrown7 I'll let you review the API/parser part |
CharlleDaniel
force-pushed
the
add_compliance_information
branch
from
bf345c0 to
94a37f5
Compare
|
Checked commit CharlleDaniel@94a37f5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
|
@rodneyhbrown7 Could you review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is able to :
refresh_parser.rbandparser.rb.