Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing classes to list APPLIES_TO_CLASS_BASE_MODELS #2785

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

h-kataria
Copy link
Contributor

Added code back that was removed during refactoring to show different set of buttons when running a Dialog thru a custom button in VM explorer.

https://bugzilla.redhat.com/show_bug.cgi?id=1515433
Issue #2754

before:
image

image

after:
screenshot from 2017-11-21 10-49-21

screenshot from 2017-11-21 10-52-34

Added code back that was removed during refactoring to show different set of buttons when running a Dialog thru a custom button in VM explorer.

https://bugzilla.redhat.com/show_bug.cgi?id=1515433
Issue ManageIQ#2754
@miq-bot
Copy link
Member

miq-bot commented Nov 21, 2017

Checked commit h-kataria@8d49676 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@dclarizio dclarizio merged commit 318c4e4 into ManageIQ:master Nov 21, 2017
@dclarizio dclarizio added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 21, 2017
simaishi pushed a commit that referenced this pull request Nov 27, 2017
Added missing classes to list APPLIES_TO_CLASS_BASE_MODELS
(cherry picked from commit 318c4e4)

https://bugzilla.redhat.com/show_bug.cgi?id=1517887
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit d921c26b10086ce3c3b30798f529899932ee169e
Author: Dan Clarizio <[email protected]>
Date:   Tue Nov 21 15:17:47 2017 -0800

    Merge pull request #2785 from h-kataria/dialog_form_buttons_fix
    
    Added missing classes to list APPLIES_TO_CLASS_BASE_MODELS
    (cherry picked from commit 318c4e4586064d092021da7e1e3b3694ef83b10f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517887

@h-kataria h-kataria deleted the dialog_form_buttons_fix branch December 1, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants