"Save" button appears instead of "Submit"

[smelamud]

I'm working on this service dialog:
https://github.com/ManageIQ/manageiq-providers-ovirt/blob/master/content/service_dialogs/transform-vm.yml

After updating to the latest master the following issue appeared: when I use the dialog, 'Save' button appears instead of 'Submit' button. Pressing the 'Save' button does not submit the dialog as before, but displays "Save Button not yet implemented" message.

The dialog is actually wired to a real button in the UI. Not a serviceor custom button.

The yaml file says:

---
- description: Transform VM
  buttons: submit,cancel
  label: Transform VM
  dialog_tabs:

But actually save/reset/cancel buttons are displayed.

[dclarizio]

@gmcculloug @eclarizio @chalettu any thoughts on why we would be showing a Save button instead of Submit when the yaml file clearly shows submit?

[gmcculloug]

Hoping @eclarizio has some insight here. The shared dialog runner was not implemented here yet so not sure what's going on.

[eclarizio]

@dclarizio Definitely odd, as @gmcculloug says the new dialog component was not implemented yet and I don't recall touching anything related to these buttons. So unfortunately I do not have any insight at first glance, would need to take a deeper look.

[jelkosz]

It breaks the mass transformation feature (https://bugzilla.redhat.com/show_bug.cgi?id=1491182).

[jelkosz]

@miq-bot add_label bug, blocker

[jelkosz]

@martinpovolny @gmcculloug Any chance someone could have a look at this? This issue renders our transform dialog useless. And I would say that any similar dialog would be affected the same way.

[smelamud]

Added BZ to make the issue more visible: https://bugzilla.redhat.com/show_bug.cgi?id=1515433

[gmcculloug]

@dclarizio @h-kataria Thoughts on who can look into this? @eclarizio has not made any changes in this area with the dialog work but maybe he can help someone from the UI team look into it. Let me know if I can help in any way.

[h-kataria]

@smelamud do you have screenshot of the screen, i wasn't able to recreate this locally.

[smelamud]

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[JPrause]

@smelamud is this still a valid issue? If yes, lease remove the stale label. If not can you close.
If there's no update by next week, I'll be closing this issue.