Fixed replace_right_cell regression in the tag mapping on OPS screen

[skateman]

The regression was introduced in #2522 by missing to add the condition for the active_subtab. We should not fetch partial names so dynamically btw. You can reproduce the issue by visiting Settings -> Region (treenode) -> Tags (tab) -> Map Tags (subtab), try to add a new mapping or just hit the cancel button.

@miq-bot add_label bug, gaprindashvili/yes

https://bugzilla.redhat.com/show_bug.cgi?id=1513507

[miq-bot]

Checked commit skateman@5d8468f with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

[cben]

✅ Works nicely.

• Add / Save now work from 1st click, with no error messages and with a green success message.
• Cancel now works (didn't at all), with a green "cancelled" message.

P.S. I wish such screens would be more like a "component" with their own independent controller, that could be attached as an explorer row / tab / subtab without internal surgery...

[h-kataria]

looks good.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 85ff0bebbea4cb407f6ecea1a50e9910a524550b
Author: Harpreet Kataria <[email protected]>
Date:   Tue Nov 21 13:49:52 2017 -0500

    Merge pull request #2749 from skateman/fix-tagging-replace
    
    Fixed replace_right_cell regression in the tag mapping on OPS screen
    (cherry picked from commit ba169c8b207712a660727d4fd559fd41576c9423)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517855