Move tagging-related tabs into subtabs on the Settings/Region screen #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
ops-2nd-level-tabs
branch
from
707f150 to
1ea2021
Compare
|
@miq-bot add_label formatting/styling, enhancement, fine/no |
skateman
force-pushed
the
ops-2nd-level-tabs
branch
from
1ea2021 to
e084120
Compare
|
@skateman Tested. Looks good. |
|
looks good, can be merged once Travis is green, test failures are not related to changes in this PR |
skateman
force-pushed
the
ops-2nd-level-tabs
branch
from
e084120 to
a743672
Compare
|
Checked commits skateman/manageiq-ui-classic@36d5211~...a743672 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/ops_controller/settings/common.rb
app/views/ops/_all_tabs.html.haml
|
|
merging, test failures are not related to changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have enough space for the help menu customization I had to free up some space among the tabs on the
Settings -> Regionscreen. The solution proposed by the UX team was to join the tabs related to tagging into a single tab and create a second level of tabs.I introduced a new
:active_subtabkey in the sandbox for distinguishing. Unfortunately, the tab switching logic inmiq_tabs_initconcatenates atab_idafter the URL and it is too widely used. So I introduced a hack: we still send thetab_idfor the second level tabs, but we append theparent_tab_idparameter to minimize the number of changes in the controller. I know it is ugly and I'm sorry for this 😢 but it will be gone when we convert this screen to angular.There were some issues with the
flash_msg_divwhen switching tabs, so as @martinpovolny suggested, I went through all the partials and moved the div to a single place above the first level of tabs.Before:
After:
@martinpovolny and @epwinchell can you please review?