Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable credentials validation for Lenovo provider #2650

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Enable credentials validation for Lenovo provider #2650

merged 1 commit into from
Nov 9, 2017

Conversation

tumido
Copy link
Member

@tumido tumido commented Nov 7, 2017

This change allow proper credentials verification on Lenovo provider

Depends on: ManageIQ/manageiq-providers-lenovo#108

@tumido tumido mentioned this pull request Nov 7, 2017
Merged
@tumido
Copy link
Member Author

tumido commented Nov 7, 2017

cc @jntullo

@miq-bot
Copy link
Member

miq-bot commented Nov 7, 2017

Checked commit tumido@e2fed68 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@tumido tumido mentioned this pull request Nov 7, 2017
Merged
@tumido
Copy link
Member Author

tumido commented Nov 8, 2017

Back end PR is merged
@miq-bot add_label compute/physical infrastructure, bug

@mzazrivec mzazrivec self-assigned this Nov 9, 2017
@mzazrivec mzazrivec added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 9, 2017
@mzazrivec mzazrivec merged commit d8da2db into ManageIQ:master Nov 9, 2017
simaishi pushed a commit that referenced this pull request Nov 15, 2017
@mzazrivec @simaishi
Merge pull request #2650 from tumido/fix_cred_validation_lenovo
ec5b4e3 
Enable credentials validation for Lenovo provider
(cherry picked from commit d8da2db)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit ec5b4e34af5da55d9b43d1753ea44318c9ebb9e0
Author: Milan Zázrivec <[email protected]>
Date:   Thu Nov 9 11:06:44 2017 +0100

    Merge pull request #2650 from tumido/fix_cred_validation_lenovo
    
    Enable credentials validation for Lenovo provider
    (cherry picked from commit d8da2db5104d2dad0e60d160a5597cfcada322e8)

@tumido tumido deleted the fix_cred_validation_lenovo branch June 26, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug compute/physical infrastructure gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tumido @miq-bot @simaishi @mzazrivec