-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception handing for credential validation on raw_connect #40
Conversation
cc @jntullo |
e2d3844
to
ec21b28
Compare
Checked commit tumido@ec21b28 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
@gberginc - can you review. |
Code LGTM @gasper.vrhovsek please check @miq-bot add_label bug, gaprindashvili/yes |
@gberginc LGTM |
Thanks @gasper-vrhovsek (and sorry for mistyping your username, causing the delay). @bronaghs @juliancheal this looks good now and is ready to be merged @miq-bot assign @juliancheal |
Fix exception handing for credential validation on raw_connect (cherry picked from commit 8fe2ff3)
Gaprindashvili backport details:
|
When provider is added the credentials validation is newly done via
raw_connect
(class method) instead ofverify_credentials
(needed EMS object). Further reading on this change can be found here: ManageIQ/manageiq-ui-classic#1580This change ensures that exceptions are handled properly, because the
verify_credentials
is not called anymore.Similar PRs for other providers: