Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception handing for credential validation on raw_connect #40

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

tumido
Copy link
Member

@tumido tumido commented Nov 7, 2017

When provider is added the credentials validation is newly done via raw_connect (class method) instead of verify_credentials (needed EMS object). Further reading on this change can be found here: ManageIQ/manageiq-ui-classic#1580

This change ensures that exceptions are handled properly, because the verify_credentials is not called anymore.

Similar PRs for other providers:

@tumido
Copy link
Member Author

tumido commented Nov 7, 2017

cc @jntullo

@tumido tumido force-pushed the fix_cred_validation branch from e2d3844 to ec21b28 Compare November 7, 2017 12:31
@miq-bot
Copy link
Member

miq-bot commented Nov 7, 2017

Checked commit tumido@ec21b28 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@bronaghs
Copy link

@gberginc - can you review.

@gberginc
Copy link
Contributor

Code LGTM

@gasper.vrhovsek please check

@miq-bot add_label bug, gaprindashvili/yes

@gasper-vrhovsek
Copy link
Contributor

@gberginc LGTM

@gberginc
Copy link
Contributor

Thanks @gasper-vrhovsek (and sorry for mistyping your username, causing the delay).

@bronaghs @juliancheal this looks good now and is ready to be merged

@miq-bot assign @juliancheal

@bronaghs bronaghs merged commit 8fe2ff3 into ManageIQ:master Nov 21, 2017
@bronaghs bronaghs added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 21, 2017
simaishi pushed a commit that referenced this pull request Nov 21, 2017
Fix exception handing for credential validation on raw_connect
(cherry picked from commit 8fe2ff3)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 810dfb18dd361bb9ca88f77738aed7e3d5575b24
Author: Bronagh Sorota <[email protected]>
Date:   Tue Nov 21 08:53:30 2017 -0500

    Merge pull request #40 from tumido/fix_cred_validation
    
    Fix exception handing for credential validation on raw_connect
    (cherry picked from commit 8fe2ff3832896badfe556e916f92d706b1cc1204)

@tumido tumido deleted the fix_cred_validation branch June 26, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants