Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use miqObserveRequest to force dialog submit to wait for auto refresh #2397

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Use miqObserveRequest to force dialog submit to wait for auto refresh #2397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/assets/javascripts/dialog_field_refresh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* global miqInitSelectPicker miqSelectPickerEvent miqSparkle miqSparkleOn */
/* global miqInitSelectPicker miqObserveRequest miqSelectPickerEvent miqSparkle miqSparkleOn */

var dialogFieldRefresh = {
unbindAllPreviousListeners: function() {
Expand Down Expand Up @@ -238,7 +238,7 @@ var dialogFieldRefresh = {
},

sendRefreshRequest: function(url, data, doneFunction) {
miqJqueryRequest(url, {
miqObserveRequest(url, {
data: data,
dataType: 'json',
beforeSend: true,
Expand Down
17 changes: 17 additions & 0 deletions spec/javascripts/dialog_field_refresh_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,4 +923,21 @@ describe('dialogFieldRefresh', function() {
});
});
});

describe('#sendRefreshRequest', function() {
beforeEach(function() {
spyOn(window, 'miqObserveRequest');
});

it('delegates to miqObserveRequest', function() {
dialogFieldRefresh.sendRefreshRequest('the url', 'the data', 'the done function');
expect(window.miqObserveRequest).toHaveBeenCalledWith('the url', {
data: 'the data',
dataType: 'json',
beforeSend: true,
complete: true,
done: 'the done function'
});
});
});
});