Use miqObserveRequest to force dialog submit to wait for auto refresh

[eclarizio]

There was a small race condition before where while ordering a dialog, if the user had typed in something into a text box without tabbing away or clicking elsewhere, they could click the submit button and potentially submit the form before any auto refreshes were actually done processing.

This fix simply adds the auto refreshes to the observe queue which forces the submit to wait until they are finished.

https://bugzilla.redhat.com/show_bug.cgi?id=1499589

/cc @gmcculloug

@miq-bot add_label bug, euwe/yes, fine/yes
@miq-bot assign @h-kataria

@himdel We talked about this a bit throwing around ideas, but...ends up the simplest idea worked the best, haha!
@AparnaKarve Think you can review? Would be nice to get this in asap so we can get a hotfix for the customer and I think @himdel is gone for the day.
@h-kataria Can you merge when everything is good to go?

[miq-bot]

Checked commit eclarizio@c2701cc with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

[eclarizio]

Spec failures seem unrelated, can someone restart it?

[AparnaKarve]

@eclarizio Using miqObserveRequest seems reasonable for the scenario you have mentioned above.

I just have one question - because of this change, do you foresee a situation where the autorefresh may take way too much time than actually necessary?

EDIT: Or maybe it does not matter, because the user has already submitted the form?

[eclarizio]

It shouldn't take any longer than it did before this change, so that's not a worry. When we move to the new triggering of auto refreshes instead, this will be obsolete anyway as well.

[AparnaKarve]

Ok, that sounds good. Thanks.

@h-kataria IMO, GTG.

When we move to the new triggering of auto refreshes instead,

As in, a refactored auto refresh?

[eclarizio]

@AparnaKarve Yeah, sort of. Basically instead of using the auto refresh/trigger auto refresh checkboxes, users will be able to select specific fields they would like that field to refresh, and this will happen simultaneously instead of right now which is just like a cascading one after another.

[simaishi]

Fine backport details:

$ git log -1
commit 35beb5e894ab2232b24b1e3083f26b23a827ba10
Author: Harpreet Kataria <[email protected]>
Date:   Mon Oct 16 10:25:19 2017 -0400

    Merge pull request #2397 from eclarizio/BZ1499589
    
    Use miqObserveRequest to force dialog submit to wait for auto refresh
    (cherry picked from commit 8dd216a26aec3117bfc6e6f18f0bd0dab48573b7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1502738

[simaishi]

Euwe backport details:

$ git log -1
commit d54693403f7d55cda97ad31ff88d4629b72439fd
Author: Harpreet Kataria <[email protected]>
Date:   Mon Oct 16 10:25:19 2017 -0400

    Merge pull request #2397 from eclarizio/BZ1499589
    
    Use miqObserveRequest to force dialog submit to wait for auto refresh
    (cherry picked from commit 8dd216a26aec3117bfc6e6f18f0bd0dab48573b7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1502739