Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding status field in Domain's Summary page's properties section. #2223

Merged
merged 5 commits into from
Oct 5, 2017
Merged

Adding status field in Domain's Summary page's properties section. #2223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64b1ec8
Adding status field into properties table for Domain#summary
xeviknal Sep 25, 2017
8d1f12a
MiddlewareDomain#status is not available anymore
xeviknal Oct 4, 2017
916a45f
Add translations
xeviknal Oct 4, 2017
36e612f
State now is got from MiddlewareDomainHelper instead of the generic one
xeviknal Oct 4, 2017
0d06d3f
Availaility translations removed. They are going to be in another PR
xeviknal Oct 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/middleware_domain_helper/textual_summary.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module MiddlewareDomainHelper::TextualSummary
def textual_group_properties
TextualGroup.new(_("Properties"), %i(name nativeid))
TextualGroup.new(_("Properties"), %i(name nativeid status))
end

def textual_group_relationships
Expand Down
4 changes: 4 additions & 0 deletions app/helpers/middleware_summary_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ def textual_nativeid
@record.nativeid
end

def textual_status
@record.status
Copy link
Member

@abonas abonas Sep 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think translation is needed, similar to the below - how tags are handled.
@mtho11 @karelhala is that indeed so?

end

def textual_group_smart_management
TextualTags.new(_("Smart Management"), %i(tags))
end
Expand Down