Adding status field in Domain's Summary page's properties section. #2223
Conversation
|
Pending PR in schema is ManageIQ/manageiq-schema#72 |
|
@dclarizio why is the fine/no flag needed now? |
|
@xeviknal for UI related changes, a screenshot is required in the first comment in the PR so the reviewers (and especially those who are not in the middleware team) can easily understand what's that about. So, please add a screenshot. |
| @@ -9,6 +9,10 @@ def textual_nativeid | |||
| @record.nativeid | |||
| end | |||
|
|
|||
| def textual_status | |||
| @record.status | |||
There was a problem hiding this comment.
I think translation is needed, similar to the below - how tags are handled.
@mtho11 @karelhala is that indeed so?
|
@karelhala @mtho11 please review |
|
@abonas added the screenshots |
|
@abonas I normally set enhancements to not be backported . . . feel free to change or remove the flag if you know better. 😄 |
|
@dclarizio I'm with you on this :) , but we are not during that time of release, and I do not see anyone in any other repo setting those flags, hence I wondered. |
|
@abonas thanks . . . I figure I'll make my best guess and I try to fill in at least one purple label along with any version labels I can when I first touch the PRs. I just don't like non-labeled content. :) |
|
@karelhala and @dclarizio could you please check I am not messing anything in here, please? |
|
@xeviknal just wondering if you think the status should be |
|
@dclarizio I see most of the statuses are titleized (capitalized). Althought I have just seen deploys/servers' statuses are not translated, they are printed as they come from database. Then 2 thing:
From my point of view, I would do both of them. |
|
@xeviknal I'd do them both, I just think it looks nicer. Up to you if that should be done in a separate PR. |
|
@dclarizio I was thinking exactly the same. Probably, I would do that in another PR. In order no to mix purposes. |
|
Checked commits xeviknal/manageiq-ui-classic@64b1ec8~...0d06d3f with ruby 2.3.5, rubocop 0.47.1, and haml-lint 0.20.0 |
This PR is related to #44. It only adds a new property field into Domain's summary page.
Domain's summary page:
Here the addition:
