Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Container Template" type support in Catalog Item editor #1634

Merged

Conversation

h-kataria
Copy link
Contributor

Updated summary screen to show Container Template specific details

https://www.pivotaltracker.com/story/show/147300897

Something got messed up on original PR #1621, creating a new PR
container_template_type_catalog_item

catalog_item_form

summary_screen

@h-kataria
Copy link
Contributor Author

@lfu For this release, removed reconfigure and retirement entry points from UI for Container Template type Catalog Items. Please see other 2 corrupted PRs for older comments related to changes in this PR #1625 & #1621

@lfu
Copy link
Member

lfu commented Jul 3, 2017

LGTM 👍

@gmcculloug
Copy link
Member

Ultimately I see reconfigure and retirement entry points coming back into this configuration, but for now this is a good start and we can get feedback.

@h-kataria h-kataria force-pushed the container_template_catalog_item branch from 459f958 to 38eaecb Compare July 6, 2017 17:40
@h-kataria
Copy link
Contributor Author

@dclarizio added spec tests, please review/merge

@h-kataria h-kataria force-pushed the container_template_catalog_item branch from 38eaecb to 011fead Compare July 6, 2017 18:56
@miq-bot
Copy link
Member

miq-bot commented Jul 6, 2017

Checked commits h-kataria/manageiq-ui-classic@59039d4~...011fead with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 8 offenses detected

app/controllers/catalog_controller.rb

app/views/catalog/_form_basic_info.html.haml

  • ⚠️ - Line 154 - Missing curly braces around a hash parameter.
  • ⚠️ - Line 177 - Missing curly braces around a hash parameter.
  • ⚠️ - Line 1 - Prefer to_s over string interpolation.

spec/controllers/catalog_controller_spec.rb

@dclarizio dclarizio merged commit d74c735 into ManageIQ:master Jul 6, 2017
@dclarizio dclarizio added this to the Sprint 64 Ending Jul 10, 2017 milestone Jul 6, 2017
@h-kataria h-kataria deleted the container_template_catalog_item branch August 16, 2017 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants