-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] - Added "Container Template" type support in Catalog Item editor #1621
[WIP] - Added "Container Template" type support in Catalog Item editor #1621
Conversation
d3742cb
to
0c87ed8
Compare
@lfu @gmcculloug ready to test, i am working on adding spec tests |
0c87ed8
to
01f081a
Compare
@h-kataria Looks good. @lfu Please test. |
@@ -1560,6 +1573,16 @@ def add_ansible_tower_job_template_vars(st) | |||
nil : ConfigurationScript.find_by(:id => @edit[:new][:template_id]) | |||
end | |||
|
|||
def add_ansible_tower_container_template_vars(st) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this method is only for container template and not for ansible tower.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lfu this is common method for both types.
@h-kataria The Entry Point for Reconfigure and Retirement seems disabled in your screen shot. But they are active and selectable in my testing. Method |
st.options = { | ||
:config_info => { | ||
:provision => { | ||
:container_template_id => @edit[:new][:template_id] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This container_template_id is container template specific. How can it be shared with ansible tower? Or that will be added later?
877e887
to
29c4227
Compare
Checked commit h-kataria@29c4227 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/catalog_controller.rb
|
@gmcculloug @bzwei For this release, reconfigure and retirement are not supported. Should we hide the entry points for them from UI? |
29c4227
to
98e0436
Compare
Updated summary screen to show Container Template specific details
https://www.pivotaltracker.com/story/show/147300897