Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[URGENT] Network Router now uses raw methods #115

Merged
merged 1 commit into from
Jan 10, 2017
Merged

[URGENT] Network Router now uses raw methods #115

merged 1 commit into from
Jan 10, 2017

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Jan 10, 2017 •
edited
Loading

Realign raw methods call according to ManageIQ/manageiq#13072

This will fix CI which fails because above change was made in manageiq repo

@gildub gildub changed the title Network Router now uses raw methods [URGENT] Network Router now uses raw methods Jan 10, 2017
@miq-bot
Copy link
Member

miq-bot commented Jan 10, 2017

Checked commit https://github.com/gildub/manageiq-ui-classic/commit/a22ecbb45a8dcd7869bf34acbd42726838f51334 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🏆

@martinpovolny martinpovolny merged commit 1772fcd into ManageIQ:master Jan 10, 2017
@martinpovolny martinpovolny self-assigned this Jan 10, 2017
@martinpovolny martinpovolny added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 10, 2017
@gildub gildub deleted the network_router_raw_commands_in_spec branch January 10, 2017 07:29
@Ladas Ladas mentioned this pull request Jan 10, 2017
Merged
@gildub gildub mentioned this pull request Jan 12, 2017
Closed
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 2170398cf5bd5f530abf9b901e7015a1c7f7db03
Author: Martin Povolny <[email protected]>
Date:   Tue Jan 10 07:34:57 2017 +0100

    Merge pull request #115 from gildub/network_router_raw_commands_in_spec
    
    [URGENT] Network Router now uses raw methods
    (cherry picked from commit 1772fcdb135f2b59435879268e8a22c007d16b5a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1413677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
blocker bug compute/cloud euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gildub @miq-bot @simaishi @martinpovolny