Policy Event must have at least one action assigned to it #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
policy_event_action_fix
branch
from
275ed43 to
7f40c95
Compare
h-kataria
force-pushed
the
policy_event_action_fix
branch
from
7f40c95 to
bf306f3
Compare
|
@Ladas can you take a look failing tests on this PR, those are unrelated to changes in this PR, seems to be failing in NetworkRouterController |
|
@h-kataria seems like it's fixed in #115, so you just need to rebase |
|
@h-kataria, @Ladas, yes I confirm, sorry about the split issue! |
Made changes to not allow deleting all actions from a Policy Event, at least one action should be there. https://bugzilla.redhat.com/show_bug.cgi?id=1395965
h-kataria
force-pushed
the
policy_event_action_fix
branch
from
bf306f3 to
92d6591
Compare
|
Checked commit h-kataria@92d6591 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 spec/controllers/miq_policy_controller/events_spec.rb
|
|
Euwe backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to not allow deleting all actions from a Policy Event, at least one action should be there.
https://bugzilla.redhat.com/show_bug.cgi?id=1395965
before:
after:
@dclarizio please review