ToolbarController - always $digest after Rx message #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jzigmund : As you where close to this problem, can you, please, test this? |
|
@martinpovolny already done, it's not fixing my BZ though :-/ already contacted @himdel to look again and find the working bugfix |
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/39210ff99781e5715d1b83ed6e57c3931a5610f3~...b808cbff9e64bc8eaea00bf096a719c433934063 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
jzigmund
approved these changes
Apr 20, 2017
There was a problem hiding this comment.
after rebase, I can confirm that this PR is fixing https://bugzilla.redhat.com/show_bug.cgi?id=1440118
simaishi
pushed a commit
that referenced
this pull request
Apr 20, 2017
ToolbarController - always $digest after Rx message (cherry picked from commit 2128ff1) https://bugzilla.redhat.com/show_bug.cgi?id=1444176
|
Fine backport details: |
|
Euwe backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1054 - Cc @jzigmund
I gave up on trying to use
$timeout, seems like to much code is dependent on the synchronous nature right now :(.So this just makes sure that
$digestis called every time we gate an observable message, not only in the other cases. (Also verified that those methods are never called from anywhere else..)(
fine/yesbecause related to https://bugzilla.redhat.com/show_bug.cgi?id=1440118 )EUWE: https://bugzilla.redhat.com/show_bug.cgi?id=1444178 and https://bugzilla.redhat.com/show_bug.cgi?id=1444037 - please backport together with #1058