Zero the toolbar count when asked #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The angular toolbars no longer create an element with #foo_tb. So any code that needs such a div to work, and doesn't get called when the element doesn't exist is dead :). Removing
…th 0 before the toolbar refactor, miqSetButtons would set everything to the right count. It is still being called in places where we need to update the toolbar count, but doesn't work most of the time because it no longer touches any toolbars. This needs more refactoring to be clean, but for now, at least we should reset the toolbar to 0 when asked to :). https://bugzilla.redhat.com/show_bug.cgi?id=1440142
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/b3b83700e7113a0c81de2951f32f429d828cce8e~...a6740381f364b7bf77637de0860f25bf4ff55a8b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Apr 20, 2017
Zero the toolbar count when asked (cherry picked from commit 39f6b87) https://bugzilla.redhat.com/show_bug.cgi?id=1444035
|
Fine backport details: |
|
Euwe backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the toolbar refactor,
miqSetButtonswould set the right counts for toolbar.This no longer happens and
miqSetButtonsis almost dead .. except it is still being called in all the places where we want to reset the counts.So, adding a special condition to reset the toolbar count when count = 0.
https://bugzilla.redhat.com/show_bug.cgi?id=1440142
(also added euwe/yes because this is also related to https://bugzilla.redhat.com/show_bug.cgi?id=1440118, together with #1054)
This needs more cleanup, and complete refactoring of
miqUpdateButtonsandmiqUpdateAllCheckboxesandmiqSetButtons(and related code), but for now .. this fixes the bug :).When testing, the changes from #1054 are also needed to get consistent behaviour without extra clicking.
Fine BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1444035
EUWE: https://bugzilla.redhat.com/show_bug.cgi?id=1444178 and https://bugzilla.redhat.com/show_bug.cgi?id=1444037 - please backport together with #1095