Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration for Startpage url updates for CB Assignments #486

Merged
merged 1 commit into from
May 22, 2020
Merged

Migration for Startpage url updates for CB Assignments #486

merged 1 commit into from
May 22, 2020

Conversation

h-kataria
Copy link
Contributor

@gtanzillo gtanzillo mentioned this pull request May 20, 2020
Closed
12 tasks
@h-kataria h-kataria mentioned this pull request May 20, 2020
Merged
skateman
skateman approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@h-kataria h-kataria force-pushed the cb_assignment_start_page_update branch from 8bbca44 to 4be60f1 Compare May 21, 2020 16:00
@miq-bot
Copy link
Member

miq-bot commented May 21, 2020

Checked commit h-kataria@4be60f1 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 👍

@chessbyte chessbyte merged commit b699755 into ManageIQ:master May 22, 2020
@chessbyte chessbyte assigned chessbyte and unassigned skateman May 22, 2020
@h-kataria h-kataria mentioned this pull request May 22, 2020
Merged
simaishi pushed a commit that referenced this pull request May 28, 2020
@chessbyte @simaishi
Merge pull request #486 from h-kataria/cb_assignment_start_page_update
122df7e 
Migration for Startpage url updates for CB Assignments

(cherry picked from commit b699755)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit 122df7ecb2bf94f57b0c4ad53e6469f9aafe434c
Author: Oleg Barenboim <[email protected]>
Date:   Fri May 22 15:24:52 2020 -0400

    Merge pull request #486 from h-kataria/cb_assignment_start_page_update

    Migration for Startpage url updates for CB Assignments

    (cherry picked from commit b699755b37cb29042820ccd2f79e93178310ca6f)

@h-kataria h-kataria deleted the cb_assignment_start_page_update branch January 12, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

@skateman skateman skateman approved these changes

Assignees

@chessbyte chessbyte

Labels
enhancement jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@h-kataria @miq-bot @simaishi @skateman @bdunne @chessbyte