Add an empty database spec #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
force-pushed
the
empty_database_spec
branch
from
ea44516 to
b234145
Compare
carbonin
reviewed
Aug 7, 2018
| @@ -0,0 +1,20 @@ | |||
| describe "Empty Database" do | |||
| let(:connection) { ApplicationRecord.connection } | |||
There was a problem hiding this comment.
I know we use ActiveRecord::Base in the actual migrations. Should we use it here too?
| @@ -0,0 +1,11 @@ | |||
| describe "Empty Database" do | |||
| it "after migrated remains empty" do | |||
| counts = ApplicationRecord.connection.tables.each_with_object([]) do |t, array| | |||
There was a problem hiding this comment.
Should we use ActiveRecord::Base.connection here? I know we use it in the migrations, but wasn't sure if we should in the specs as well.
| counts = ApplicationRecord.connection.tables.each_with_object([]) do |t, array| | ||
| next if ManageIQ::Schema::SYSTEM_TABLES.include?(t) | ||
| count = ApplicationRecord.connection.execute("SELECT COUNT(*) FROM #{t};").getvalue(0, 0) | ||
| array << "#{t}: #{count}" if count.positive? |
There was a problem hiding this comment.
What about negative row counts 😱 
Only the schema itself should change
bdunne
force-pushed
the
empty_database_spec
branch
from
b234145 to
db33c1b
Compare
|
Checked commits bdunne/manageiq-schema@37a42d2~...db33c1b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
carbonin
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty database (migrated form 0) should remain empty, only the schema itself should change.
Adding this as an automated code review to address #4 (comment)